Skip to content

[image_picker] Handle a null stream from openInputStream - #12718

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
mboetger:fix-null-stream-191988
Sep 10, 2026
Merged

[image_picker] Handle a null stream from openInputStream#12718
auto-submit[bot] merged 3 commits into
flutter:mainfrom
mboetger:fix-null-stream-191988

Conversation

@mboetger

@mboetger mboetger commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Null safety when ContentResolver cannot open a stream.

Copied from closed: #12682

Fixes: flutter/flutter#191988

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a potential NullPointerException crash in the Android image_picker plugin by adding a null check for the InputStream returned by ContentResolver#openInputStream() in FileUtils.java. If the stream is null, the method returns null. A unit test has been added to verify this behavior, and the package version is bumped to 0.8.13+22. There are no review comments, so there is no feedback to provide.

@mboetger
mboetger requested a review from gmackall September 10, 2026 19:19
@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2026
@auto-submit

auto-submit Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12718, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2026
@auto-submit
auto-submit Bot merged commit c177dfc into flutter:main Sep 10, 2026
11 of 13 checks passed
pull Bot pushed a commit to Mattlk13/flutter that referenced this pull request Sep 11, 2026
…r#192630)

flutter/packages@8a35b16...9caa77c

2026-09-11 tarrinneal@gmail.com [pigeon] main actor async flutter api
(flutter/packages#12729)
2026-09-10 matt.boetger@gmail.com [image_picker] Handle a null stream
from openInputStream (flutter/packages#12718)
2026-09-10 47866232+chunhtai@users.noreply.github.com [material_ui]
1.2.0 sync back clean up (flutter/packages#12829)
2026-09-10 50643541+Mairramer@users.noreply.github.com [material_ui]
Support custom date input formatters via CalendarDelegate
(flutter/packages#12608)
2026-09-10 louisehsu@google.com [in_app_purchase_storekit] Expose
expiration date directly for subscriptions (flutter/packages#11551)
2026-09-10 matt.boetger@gmail.com [file_selector_android] Handle a null
stream from openInputStream (flutter/packages#12716)
2026-09-10 tarrinneal@gmail.com [pigeon] Add FFI and JNI support to
Swift and Kotlin (flutter/packages#11352)
2026-09-10 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Migrate M3 Card defaults to new gen_defaults (flutter/packages#12795)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: image_picker platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[image_picker] Android: uncaught NullPointerException in FileUtils.copy when openInputStream returns null (process crash)

2 participants